Next Config Override #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mathu97 merged 29 commits into main from feat/override-next-config

Mar 10, 2025

Collaborator

mathu97 commented Mar 4, 2025 •

edited

Loading

Overrides the user's Next Config file to add configs optimized for Firebase App Hosting. Currently sets images.unoptimized to true unless user has it explicitly defined to false or has a custom image loader.

mathu97 and others added 3 commits

March 3, 2025 15:38


          add function to override next config

46e9f48


          implement next config override logic to import in existing config and…

e4c1966

… export overrided config


          add unit tests for next config overrides

7924e7b

jamesdaniels reviewed

View reviewed changes

packages/@apphosting/adapter-nextjs/src/overrides.ts Outdated Show resolved Hide resolved

jamesdaniels reviewed

View reviewed changes

packages/@apphosting/adapter-nextjs/src/overrides.ts Outdated Show resolved Hide resolved

jamesdaniels reviewed

View reviewed changes

packages/@apphosting/adapter-nextjs/src/overrides.ts Outdated Show resolved Hide resolved

jamesdaniels reviewed

View reviewed changes

packages/@apphosting/adapter-nextjs/src/overrides.ts Outdated Show resolved Hide resolved

jamesdaniels reviewed

View reviewed changes

packages/@apphosting/adapter-nextjs/src/overrides.ts Outdated Show resolved Hide resolved

mathu97 added 8 commits

March 5, 2025 17:25


          address some comments

b670497


          fix test

af99265


          use rename instead of read/write

c6626f9


          progress - e2e tests

4a8401a


          mostly working e2e tests

074d6a0


          support async next configs

8b72920


          debug

141d46e


          fix up e2e tests

1e98f4f

mathu97 marked this pull request as ready for review

March 6, 2025 18:43

mathu97 requested review from Yuangwang, blidd-google, leoortizz, sjjj986, taeold and tonyjhuang as code owners

March 6, 2025 18:43

mathu97 added 7 commits

March 6, 2025 14:07


          add additional tests and fix lint errors

70e1bd8


          fix lint

442a69a


          some debug logs

cc64e3d


          Merge remote-tracking branch 'origin/main' into feat/override-next-co…

2d6718a

…nfig


          remove console logs

560f0d8


          set debuggability for e2e test

5a1ce3c


          remove usage of libraries to fix e2e

9d6ee74


          fix e2e

be9d381

mathu97 requested a review from jamesdaniels

March 7, 2025 02:03


          add jsdocs

mathu97 requested a review from annajowang

March 7, 2025 17:09

annajowang reviewed

View reviewed changes

packages/@apphosting/adapter-nextjs/src/overrides.ts Outdated Show resolved Hide resolved

packages/@apphosting/adapter-nextjs/src/overrides.ts Show resolved Hide resolved

packages/@apphosting/adapter-nextjs/src/overrides.ts Outdated Show resolved Hide resolved

jamesdaniels reviewed

View reviewed changes

packages/@apphosting/adapter-nextjs/src/overrides.ts Outdated Show resolved Hide resolved

mathu97 and others added 5 commits

March 8, 2025 04:36


          bump version

2bdecf0


          address pr comments

85cea6e


          fix errors

fff3505


          add validate next config override function

a2dc2eb


          just loadconfig again instead of checking anything else

bd62abe

annajowang approved these changes

View reviewed changes

Collaborator

annajowang left a comment

lgtm after github lint comment is resolved.

mathu97 and others added 4 commits

March 10, 2025 16:35


          fix breaking tests

726342e


          add validation that override worked

d7ce5da


          fix tests again

ec84af3


          add overrides validation unit tests

mathu97 requested a review from jamesdaniels

March 10, 2025 19:08

jamesdaniels approved these changes

View reviewed changes

mathu97 merged commit c02e7b3 into main

10 checks passed

mathu97 deleted the feat/override-next-config branch

March 10, 2025 21:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jamesdaniels jamesdaniels approved these changes

annajowang annajowang approved these changes

Yuangwang Awaiting requested review from Yuangwang Yuangwang is a code owner

sjjj986 Awaiting requested review from sjjj986 sjjj986 is a code owner

tonyjhuang Awaiting requested review from tonyjhuang

blidd-google Awaiting requested review from blidd-google blidd-google is a code owner

taeold Awaiting requested review from taeold taeold is a code owner

leoortizz Awaiting requested review from leoortizz leoortizz is a code owner

Labels

None yet